Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingvin-share: 1.6.1 -> 1.7.0 #366607

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

RatCornu
Copy link
Contributor

Changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 20, 2024
Copy link
Member

@szlend szlend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 packages built:
pingvin-share.backend pingvin-share.frontend

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366607


x86_64-linux

✅ 2 packages built:
  • pingvin-share.backend
  • pingvin-share.frontend

@szlend
Copy link
Member

szlend commented Dec 21, 2024

2 packages built:
pingvin-share.backend pingvin-share.frontend

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366607


aarch64-darwin

✅ 2 packages built:
  • pingvin-share.backend
  • pingvin-share.frontend

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 21, 2024
@donovanglover donovanglover merged commit 484c483 into NixOS:master Dec 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants