Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handheld-daemon: 3.7.0 -> 3.8.1 #366498

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for handheld-daemon is: Linux support for handheld gaming devices like the Legion Go, ROG Ally, and GPD Win

meta.homepage for handheld-daemon is: https://github.com/hhd-dev/hhd/

meta.changelog for handheld-daemon is: https://github.com/hhd-dev/hhd/releases/tag/v3.8.1

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.8.1 with grep in /nix/store/b1q194968p3jh7i6b5ll5r3mqdxw849d-handheld-daemon-3.8.1
  • found 3.8.1 in filename of file in /nix/store/b1q194968p3jh7i6b5ll5r3mqdxw849d-handheld-daemon-3.8.1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

handheld-daemon
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/b1q194968p3jh7i6b5ll5r3mqdxw849d-handheld-daemon-3.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A handheld-daemon https://github.com/r-ryantm/nixpkgs/archive/8ef0f798a6fa82d85224c568097d216bc9c0af66.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/8ef0f798a6fa82d85224c568097d216bc9c0af66#handheld-daemon

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/b1q194968p3jh7i6b5ll5r3mqdxw849d-handheld-daemon-3.8.1
ls -la /nix/store/b1q194968p3jh7i6b5ll5r3mqdxw849d-handheld-daemon-3.8.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 2 packages built:
  • handheld-daemon
  • handheld-daemon.dist

Maintainer pings

cc @appsforartists @toast003 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 19, 2024
@appsforartists
Copy link
Contributor

I don't see any new binary calls, so this should work. I think the bootc stuff is all optional.

It might be worth asking @antheas if there are any environment variables we should be setting.

@antheas
Copy link

antheas commented Dec 19, 2024

By definition, you are not using bootc on nixos. So it's optional. Unless that feature flag is set bootc doesn't load

And even then it's optional

@appsforartists
Copy link
Contributor

Right, I just meant in general, if there are any environment variables hhd would like us to set (because we aren't setting any).

@antheas
Copy link

antheas commented Dec 19, 2024

Currently no. All are optional features that depend mostly on kernel patches that nixos doesn't ship by default

@ofborg ofborg bot requested review from appsforartists and toast003 December 19, 2024 22:21
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 20, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 21, 2024
@wolfgangwalther wolfgangwalther merged commit 8b52d80 into NixOS:master Dec 22, 2024
44 of 45 checks passed
@r-ryantm r-ryantm deleted the auto-update/handheld-daemon branch December 23, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants