Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "prefetch-npm-deps: check response status and fail on error" #365658

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Revert "prefetch-npm-deps: check response status and fail on error" #365658

merged 1 commit into from
Dec 16, 2024
+8 −24

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Dec 16, 2024

Reverts #297863

Moving to staging-next. It's actually a significant rebuild now.

744 x86_64-darwin
4124 x86_64-linux

@vcunat vcunat merged commit a31f38a into master Dec 16, 2024
15 of 16 checks passed
@vcunat vcunat deleted the revert-297863-handle-error-fetching-npm-deps branch December 16, 2024 18:05
@nix-owners nix-owners bot requested a review from winterqt December 16, 2024 18:05
@vcunat
Copy link
Member Author

vcunat commented Dec 16, 2024

BTW, we discussed this in https://matrix.to/#/#staging:nixos.org

vcunat added a commit that referenced this pull request Dec 16, 2024
@vcunat
Reapply "prefetch-npm-deps: check response status..." (#365658)
b5673d9 
This reverts commit a31f38a, reversing
changes made to c7dcafc.

Moved from master to staging-next.  About 10k rebuilds in total.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt Awaiting requested review from winterqt

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 501-1000 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vcunat