Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreswan: fix build with gcc7 #36555

Merged
merged 1 commit into from
Mar 9, 2018
Merged

libreswan: fix build with gcc7 #36555

merged 1 commit into from
Mar 9, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 8, 2018

Motivation for this change

didn't build due to additional warnings produced by gcc7

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 8, 2018
vcunat added a commit that referenced this pull request Mar 9, 2018
@vcunat
Merge #36555: libreswan: fix build with gcc7
b8ec973 
(cherry picked from commit ffe2c4b)
coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Mar 9, 2018
@vcunat
Merge NixOS#36555: libreswan: fix build with gcc7
ffe2c4b
@vcunat vcunat merged commit 0d98016 into NixOS:master Mar 9, 2018
@xeji xeji deleted the libreswan-gcc7 branch March 9, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xeji @vcunat @GrahamcOfBorg