-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mullvad: 2024.6 -> 2024.8 and mullvad-vpn: 2024.7 -> 2024.8 #365361
mullvad: 2024.6 -> 2024.8 and mullvad-vpn: 2024.7 -> 2024.8 #365361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I do have some suggestions: split into 2 commits, the PR title is wrong as both packages were in version 2024.7
Otherwise tested and working 👍
(2024.8 includes security fixes. Some marked as This will need a manual backport: #367073 |
21c9c14
to
771c19f
Compare
|
The failures on darwin seem to be sandbox related, I don't consider them blocking. |
This brings both
mullvad
andmullvad-vpn
up-to-date.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.