Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mullvad: 2024.6 -> 2024.8 and mullvad-vpn: 2024.7 -> 2024.8 #365361

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

dscottboggs
Copy link
Contributor

This brings both mullvad and mullvad-vpn up-to-date.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@aktaboot aktaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I do have some suggestions: split into 2 commits, the PR title is wrong as both packages were in version 2024.7

Otherwise tested and working 👍

@SigmaSquadron SigmaSquadron added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 21, 2024
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Dec 21, 2024

(2024.8 includes security fixes. Some marked as high, but they're all very hard to exploit in practice.)

This will need a manual backport: #367073

@SigmaSquadron SigmaSquadron added backport release-24.11 Backport PR automatically and removed backport release-24.11 Backport PR automatically labels Dec 21, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365361


x86_64-linux

✅ 2 packages built:
  • mullvad
  • mullvad-vpn

x86_64-darwin

❌ 1 package failed to build:
  • mullvad

aarch64-darwin

❌ 1 package failed to build:
  • mullvad

@wolfgangwalther
Copy link
Contributor

The failures on darwin seem to be sandbox related, I don't consider them blocking.

@wolfgangwalther wolfgangwalther merged commit 26d8eb8 into NixOS:master Dec 22, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants