galaxy-buds-client: 5.1.0 -> 5.1.1

[Icy-Thought]

Changelogs

• https://github.com/timschneeb/GalaxyBudsClient/releases/tag/5.1.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365231

---

x86_64-linux

✅ 1 package built:

• galaxy-buds-client

---

aarch64-linux

❌ 1 package failed to build:

• galaxy-buds-client

[khaneliman]

Seems to fail the same way on master.

/build/source/GalaxyBudsClient/GalaxyBudsClient.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Host.linux-x64. No packages exist with this id in source(s): _nix

Looks like the dotnet flag was only set for x64 https://github.com/NixOS/nixpkgs/pull/365231/files#diff-0481f4c907609b2332cf110e6aad41041f189c410538e7f5613bc5fc9e3697a8R30

[khaneliman]

Could probably be simplified... but just tried and it worked.

dotnetFlags =
  lib.optionals stdenv.hostPlatform.isx86_64 [ "-p:Runtimeidentifier=linux-x64" ]
  ++ lib.optionals stdenv.hostPlatform.isAarch64 [ "-p:Runtimeidentifier=linux-arm64" ];

[Icy-Thought]

@khaneliman would you like to add those flags to the current PR or should I just do it and rebase?

[khaneliman]

@khaneliman would you like to add those flags to the current PR or should I just do it and rebase?

Figured you could add it while you're in here. If you don't feel comfortable, I can do it in a follow up PR.

[Icy-Thought]

No worries, I was just thinking of giving credits to the original author of those lines! :)
I am going to add them to my PR right away!

[khaneliman]

Says there is a merge conflict, somehow.

[Icy-Thought]

Very strange.. I can see that deps.nix is the culprit, but I do not understand why that should trigger a merge conflict.

[khaneliman]

Very strange.. I can see that deps.nix is the culprit, but I do not understand why that should trigger a merge conflict.

Just rebase on master and take your changes.

[Icy-Thought]

Alright this is strange. It appears as if something had deleted the deps.nix in master recently for the merge conflict to arise.

[Icy-Thought]

DON'T MERGE! Apparently there was a "silent" migration to deps.json instead... Someone notify when there is such change, please...

[khaneliman]

DON'T MERGE! Apparently there was a "silent" migration to deps.json instead... Someone notify when there is such change, please...

I vaguely remember a treewide nix -> json conversion being talked about for stuff like this. That could have finally happened, then. #362278

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365231

---

x86_64-linux

✅ 1 package built:

• galaxy-buds-client

---

aarch64-linux

✅ 1 package built:

• galaxy-buds-client

[khaneliman]

LGTM, thanks for handling that