texlive.tlpdb.nix: change hasRunfiles to default true and omit hashes if not required #365219
+4,308
−8,749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: TeX
veprbl
reviewed
Dec 16, 2024
| s/^containerchecksum (.*)/ sha512.run = "\1";/p | ||
| /^containerchecksum (.*)/{ | ||
| # save in holdspace, print later if hasRunfiles || hasTlpkg | ||
| s/^containerchecksum (.*)/ sha512.run = "\1";/ |
There was a problem hiding this comment.
Do we really have situations when containerchecksum is set but hasRunfiles || hasTlpkg is not satisfied?
There was a problem hiding this comment.
containerchecksum is always set because of the file tlpkg/tlobj, which we ignore, so there are packages doing that (all collections and a handful of doc only packages).
xworld21
force-pushed
the
texlive-packages-omit-hasrunfiles
branch
from
24a8442 to
47d39de
Compare
|
@GrahamcOfBorg build tests.texlive |
veprbl
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
More sed surgery in tl2nix.sed: flip the default value of the boolean
hasRunfilesto true. This reduces the size of tlpdb.nix by 5% (some 130k).nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.