itch: build from source #365210
Open
itch: build from source #365210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
pluiedev
force-pushed
the
push-pxzwlpumwrno
branch
2 times, most recently
from
01f12d9 to
7142647
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
ofborg
bot
added
11.by: package-maintainer
|
This gives me the following error: |
|
Hm, okay, seems like we might need to compile butler from scratch then |
|
It seems that butler is still currently impossible to build from source: butler> building '/nix/store/57yxrfrrwah67axnrwfza2wmhmgb7xil-butler-15.24.0.drv'
butler> Running phase: unpackPhase
butler> unpacking source archive /nix/store/smw8fr3kh7mcwvcmdmqkcs2s9dhn970k-source
butler> source root is source
butler> Running phase: patchPhase
butler> Running phase: updateAutotoolsGnuConfigScriptsPhase
butler> Running phase: configurePhase
butler> Running phase: buildPhase
butler> Building subPackage .
butler> # golang.org/x/sys/unix
butler> vendor/golang.org/x/sys/unix/mremap.go:41:10: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/sys/unix/syscall.go:82:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/sys/unix/syscall_linux.go:1018:20: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/sys/unix/syscall_linux.go:2459:9: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/sys/unix/syscall_unix.go:117:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/sys/unix/sysvshm_unix.go:32:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
butler> # golang.org/x/net/http2
butler> vendor/golang.org/x/net/http2/config.go:90:17: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:90:19: embedding interface element ~int | ~int32 | ~uint32 | ~int64 requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:91:5: invalid operation: *v < minval (type parameter T is not comparable with <)
butler> vendor/golang.org/x/net/http2/config.go:91:20: invalid operation: *v > maxval (type parameter T is not comparable with >)
butler> vendor/golang.org/x/net/http2/config.go:97:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:98:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:99:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:101:3: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:103:3: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:106:3: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
butler> vendor/golang.org/x/net/http2/config.go:106:3: too many errorsThen I'll use the built binary package like before. |
pluiedev
force-pushed
the
push-pxzwlpumwrno
branch
from
7142647 to
aed6a72
Compare
electron-packager was a *pain* to figure out. Please don't subject me to this ever again.
pluiedev
force-pushed
the
push-pxzwlpumwrno
branch
from
aed6a72 to
f55a791
Compare
|
Still the same error |
|
Looks like it wants patchelfing too..? Lemme see |
|
I'm really quite confused. I can't reproduce the error even while running butler manually, and with nix-ld disabled... |
|
I think you need to package butlerd too and replace it in the souce directory |
|
It's not quite possible yet since upstream still specifies Go 1.13 in the go.mod... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
electron-packager was a pain to figure out. Please don't subject me to this ever again.
Part of #296939
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.