Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyfa: 2.61.0 -> 2.61.3 #364987

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

paschoal
Copy link
Contributor

@paschoal paschoal commented Dec 13, 2024

update release from 2.61.0 to latest 2.61.3

Pyfa changelogs:
https://github.com/pyfa-org/Pyfa/releases/tag/v2.61.1
https://github.com/pyfa-org/Pyfa/releases/tag/v2.61.2
https://github.com/pyfa-org/Pyfa/releases/tag/v2.61.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 13, 2024
@paschoal paschoal marked this pull request as ready for review December 13, 2024 18:42
@Daholli
Copy link
Contributor

Daholli commented Dec 14, 2024

@paschoal once @ToasterUwU approved and ofborg checks are through you can try merging it with @NixOS/nixpkgs-merge-bot merge haven't tried this yet, but I presume this should work

@paschoal
Copy link
Contributor Author

@paschoal once @ToasterUwU approved and ofborg checks are through you can try merging it with @NixOS/nixpkgs-merge-bot merge haven't tried this yet, but I presume this should work

yeap! definitely a good plan, thanks!

@ToasterUwU
Copy link
Member

Pretty sure that command only works when the ryan bot made the PR.

I will test this change today

@ofborg ofborg bot requested a review from Daholli December 14, 2024 11:06
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 14, 2024
@ToasterUwU
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364987


x86_64-linux

✅ 1 package built:
  • pyfa

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Dec 15, 2024
@FliegendeWurst FliegendeWurst merged commit f6370c1 into NixOS:master Dec 15, 2024
87 of 88 checks passed
@paschoal paschoal deleted the update-pyfa-2.61.3 branch December 15, 2024 18:02
@paschoal
Copy link
Contributor Author

awesome! thanks to everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants