Update reference to built architectures #364826
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in NixOS#361521 this was changed to aarch64-darwin.
github-actions
bot
added
the
8.has: documentation
NixOSInfra
added
the
12. first-time contribution
szlend
reviewed
Dec 13, 2024
| @@ -42,7 +42,7 @@ shows the status of tests for the `nixpkgs-unstable` channel. | |||
|
|
|||
| The tests are conducted by a cluster called [Hydra](https://nixos.org/hydra/), | |||
| which also builds binary packages from the Nix expressions in Nixpkgs for | |||
| `x86_64-linux`, `i686-linux` and `x86_64-darwin`. | |||
| `x86_64-linux`, `i686-linux` and `aarch64-darwin`. | |||
There was a problem hiding this comment.
I don't think this is related to the change in #361521 which is just for building cross toolchains. This should probably mention all 4 platforms since we still build and cache x86_64-darwin.
There was a problem hiding this comment.
It is entirely possible I misunderstand the docs (wouldn't be the first time).
How do you read this paragraph in context?
I read it as: these are the platforms for which we build and cache pkgsCross packages. (Maybe only some)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #361521 this was changed to aarch64-darwin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.