Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt-launcher: fix fhsenv version #364686

Merged

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 12, 2024

part of #336576

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 12, 2024 19:14
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 12, 2024
@Stunkymonkey
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364686


x86_64-linux

✅ 1 package built:
  • bolt-launcher

Copy link
Contributor

@nezia1 nezia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For future reference, is pname the standard name that is to be used when packaging derivations in general, or is that mostly for buildFHSEnv?

@Stunkymonkey
Copy link
Contributor Author

LGTM! For future reference, is pname the standard name that is to be used when packaging derivations in general, or is that mostly for buildFHSEnv?

see: #103997

currently internally it is still used as name = "${pname}-${version}" but parsing version information (needed for updates) from the packages is hard without this split.

@Stunkymonkey Stunkymonkey merged commit a4e1cfc into NixOS:master Dec 12, 2024
34 of 35 checks passed
@Stunkymonkey Stunkymonkey deleted the bolt-launcher-fhsenv-version branch December 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants