Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-settings-daemon: 1.0.0-alpha.2 -> 1.0.0-alpha.4 #364334

Merged
merged 1 commit into from
Dec 15, 2024
Merged

cosmic-settings-daemon: 1.0.0-alpha.2 -> 1.0.0-alpha.4 #364334

merged 1 commit into from
Dec 15, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Dec 11, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 11, 2024
@a-kenji
Copy link
Contributor Author

a-kenji commented Dec 11, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364334

x86_64-linux

✅ 1 package built:
  • cosmic-settings-daemon

@a-kenji a-kenji mentioned this pull request Dec 11, 2024
Closed
13 tasks
getchoo
getchoo approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364334

aarch64-linux

✅ 1 package built:
  • cosmic-settings-daemon

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
@ofborg ofborg bot requested a review from nyabinary December 12, 2024 13:31
@Aleksanaa Aleksanaa merged commit bc0397f into NixOS:master Dec 15, 2024
38 of 39 checks passed
@a-kenji a-kenji deleted the bmp/cosmic-settings-daemon branch December 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@nyabinary nyabinary Awaiting requested review from nyabinary

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-kenji @getchoo @Aleksanaa