Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udiskie: 2.5.3 -> 2.5.7 #364303

Merged
merged 1 commit into from
Dec 12, 2024
Merged

udiskie: 2.5.3 -> 2.5.7 #364303

merged 1 commit into from
Dec 12, 2024

Conversation

dotlambda
Copy link
Member

Diff: coldfix/udiskie@v2.5.3...v2.5.7

Changelog: https://github.com/coldfix/udiskie/blob/v2.5.7/CHANGES.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 11, 2024
@getchoo getchoo added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 12, 2024
@getchoo
Copy link
Member

getchoo commented Dec 12, 2024

@ofborg build udiskie udiskie.passthru.tests

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
@getchoo getchoo merged commit f5413b0 into NixOS:master Dec 12, 2024
24 of 26 checks passed
@dotlambda dotlambda deleted the udiskie branch December 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants