Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: add shell completions #364155

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

ribru17
Copy link
Contributor

@ribru17 ribru17 commented Dec 11, 2024

Adds shell completions for bash, fish, and zsh. Tree-sitter also supports elvish and powershell, and will support nushell in the next release.

Note that I have only tested the bash completions!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teto
Copy link
Member

teto commented Dec 11, 2024

please do the formatting in a separate commit. And it's going to be formatted in the upcoming months anyway so I am not a fan of the formatting. This should target the "staging" branch considering the high number of rebuilds (please mark the PR as draft before changing the target branch to avoid pinging hundreds of people+)

@ribru17 ribru17 marked this pull request as draft December 11, 2024 17:27
Adds shell completions for `bash`, `fish`, and `zsh`. Tree-sitter also
supports `elvish` and `powershell`, and will support `nushell` in the
next release.

Note that I have only tested the bash completions!
@ribru17 ribru17 changed the base branch from master to staging December 11, 2024 17:50
@ribru17 ribru17 marked this pull request as ready for review December 11, 2024 17:56
@uncenter
Copy link
Member

I think this will conflict with #363303 (not only, but partially due to a formatting commit 😅 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants