nixos/xen: declarative libxenlight, part I
#363388
Open
+865
−878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
5 tasks
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
2 times, most recently
from
edcc253 to
fc8e8b2
Compare
hehongbo
reviewed
Dec 10, 2024
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
from
fc8e8b2 to
56a127e
Compare
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
from
56a127e to
a50402d
Compare
wegank
added
the
2.status: merge conflict
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
from
a50402d to
4c3ecc8
Compare
SigmaSquadron
removed
the
2.status: merge conflict
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
2 times, most recently
from
a901dca to
7dc40de
Compare
|
Commits have been fixed. (praise be |
hehongbo
approved these changes
Dec 11, 2024
SigmaSquadron
added
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2144 |
wegank
removed
the
12.approved-by: package-maintainer
Signed-off-by: Fernando Rodrigues <[email protected]>
Also turns the oxenstored configuration compliant with RFC 0042. Signed-off-by: Fernando Rodrigues <[email protected]>
Also adds a warning for Lanzaboote users. Signed-off-by: Fernando Rodrigues <[email protected]>
- Deduplicates the removed options functions - Inherits everything from the top-level `lib`. - Clarifies that the maintainers are the xen team members, not just `members`. - Removes some superfluous newlines Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron
force-pushed
the
push-qstqowzsmurr
branch
from
7dc40de to
9553e52
Compare
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxenstoredconfiguration compliant with RFC 0042.xlformat generator./etc/xl.confconfigurable.No guest stuff yet. That's part II.
I would like to apologise in advance to whoever reviews
formats.nix.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.