Update NixOS Module evremap #362661
Merged
Update NixOS Module evremap #362661
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow the key to be remapped start with BTN as well as KEY, to enable remapping of mouse buttons
adds the optional attribute `phys` to uniquely identify a single device, if multiple devices share the same name
filter out attrsets with a `null` value as toml doesn't support it
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
pluiedev
reviewed
Dec 9, 2024
|
@pluiedev done! |
pluiedev
approved these changes
Dec 9, 2024
|
Sorry if this is getting tedious but you mean in to squash in 3 commits right?
or do you mean squash into a single commit to have the PR as a single change? |
|
No, just the first two commits (I believe the third commit, d22eeb2, is only needed because of the phys option, so it should be squashed into that commit) |
adds the optional attribute `phys` to uniquely identify a single device, if multiple devices share the same name nixos/evremap: fix toml config generation filter out attrsets with a `null` value as toml doesn't support it nixos/evremap: use nixfmt nixos/evremap: incorporate changes from review
|
I think I borked it |
|
What steps are necessary to get this merged? |
|
Get the attention of a committer and/or linking this PR to the "PRs already reviewed" thread on the NixOS Discourse |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2151 |
Scrumplex
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the NixOS Module evremap.
I expanded the type for remappable keys to include
BTN.I added the optional
physattribute, which can be used if multiple devices share the same name. As toml doesn't supportnullvalues, I added a filter function to the toml generation.When testing the
physattribute, an error occurs that prevents the service to start if you try to switch to the new generation without a reboot. The software wants to create a uinput device but some permissions were not set immediately. After rebooting the same config worked. I'm unsure if this is something to include in the description of the attribute.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.