addNuGetDeps: support loading JSON lockfiles #362182
Closed
+41
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an initial step away from storing the nuget lockfiles as nix code, this PR makes
addNuGetDeps
more flexible about the input format.Specifically, it now imports nix, TOML, and JSON files as required. Entries in the list can either be derivations or arguments applied to
fetchNupkg
, which coerces them to derivations.This PR does not touch the output generated by
fetch-deps
and nuget-to-nix. See #358025. I probably won't have time to work on that side of things either.I've added some tests, but they're rather limited due to the lockfiles being empty. I'm open to suggestions for more robust test-cases.
cc @corngood @GGG-KILLER
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.