Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pytensor: 2.26.3 -> 2.26.4 #361595

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Dec 3, 2024

Things done

Changelog: https://github.com/pymc-devs/pytensor/releases/tag/rel-2.26.4

cc @bcdarwin @ferrine

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from bcdarwin and nidabdella December 4, 2024 15:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Dec 4, 2024
@GaetanLepage GaetanLepage force-pushed the pymc branch 3 times, most recently from ff83bb1 to 8102966 Compare December 11, 2024 17:49
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 11, 2024
@GaetanLepage GaetanLepage changed the title python312Packages.pytensor: 2.26.3 -> 2.26.4, python312Packages.pymc: 5.18.2 -> 5.19.0 python312Packages.pytensor: 2.26.3 -> 2.26.4 Dec 22, 2024
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361595


x86_64-linux

✅ 12 packages built:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist

aarch64-linux

✅ 12 packages built:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist

aarch64-darwin

✅ 12 packages built:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist

@@ -63,8 +65,9 @@ buildPythonPackage rec {
jax
jaxlib
numba
pytestCheckHook
pytest-benchmark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to run benchmarks? They require lots of resources for not much benefits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is only used for a single test. It doesn't affect the total test time in practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it if you prefer.

@SuperSandro2000 SuperSandro2000 merged commit 3871b19 into NixOS:master Dec 22, 2024
71 of 72 checks passed
@GaetanLepage GaetanLepage deleted the pymc branch December 22, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants