Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.nvim-dap-lldb: init at 2024-06-09 #360625

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

khaneliman
Copy link
Contributor

Things done

Created for nix-community/nixvim#2400 and tested with #352277 to find dependencies (it should depend on nvim-dap but they use a pcall so it actually doesn't throw an error, do we want to bundle it as a dep anyways?).

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak
Copy link
Member

(it should depend on nvim-dap but they use a pcall so it actually doesn't throw an error, do we want to bundle it as a dep anyways?)

Yes, it still fails if it can't find nvim-dap

https://github.com/julianolf/nvim-dap-lldb/blob/81273514fdb5107b79090364b57a3ff5570bea21/lua/dap-lldb.lua#L22
https://github.com/julianolf/nvim-dap-lldb/blob/81273514fdb5107b79090364b57a3ff5570bea21/lua/dap-lldb.lua#L222

@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360625


x86_64-linux

✅ 2 packages built:
  • vimPlugins.nvim-dap-lldb
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.nvim-dap-lldb
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.nvim-dap-lldb
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.nvim-dap-lldb
  • vimPluginsUpdater

@khaneliman khaneliman merged commit 2c27ab2 into NixOS:master Dec 1, 2024
15 of 16 checks passed
@khaneliman khaneliman deleted the nvim-dap-lldb branch December 1, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants