Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zotero: 7.0.8 → 7.0.10 #359851

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 28, 2024

Diff: zotero/zotero@7.0.8...7.0.10

This update has also the side effect of "unbreaking" the "Better Bibtex" plugin for Zotero.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@stephen-huan stephen-huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with nix build github:samueltardieu/nixpkgs/b65739e061fbf58aed6ef6145685b154c65ddc97#zotero and works for me; also fixes Better Bibtex's startup error TypeError: Zotero.ItemTreeManager.registerColumn is not a function.

The upstream issue is retorquere/zotero-better-bibtex#3079.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359851


x86_64-linux

✅ 1 package built:
  • zotero

x86_64-darwin

✅ 1 package built:
  • zotero

aarch64-darwin

✅ 1 package built:
  • zotero

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 1, 2024
@JulienMalka JulienMalka merged commit b6bd36b into NixOS:master Dec 4, 2024
50 of 51 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 4, 2024

Successfully created backport PR for release-24.11:

@samueltardieu samueltardieu deleted the push-kspzrwvnnssw branch January 4, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants