Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: add xonsh shell configuration #359614

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

starship: add xonsh shell configuration #359614

wants to merge 3 commits into from
+12 −1

Conversation

cswimr
Copy link

@cswimr cswimr commented Nov 27, 2024 •
edited
Loading

This PR adds support for Starship prompts in the xonsh shell. Starship has already supported xonsh for a while, and xonsh has been in Nixpkgs for a while as well, but automatic shell configuration was never added to the Starship module.

This is my first time making a pr here, if anything else is needed please lmk!

Things done

  • Built on platform(s)
    • x86_64-linux - is this relevant? it's a module change, not a package change. I did test it both locally and in a vm though
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 27, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 28, 2024
@Aleksanaa Aleksanaa requested a review from SamLukeYes December 6, 2024 14:52
@SamLukeYes
Copy link
Member

Please rebase your commits and resolve conflicts.

@cswimr cswimr force-pushed the starship-xonsh branch 2 times, most recently from 081d396 to 3903f9b Compare December 9, 2024 17:17
@github-actions github-actions bot added 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: vim 6.topic: fetch 6.topic: nodejs 6.topic: hardware 6.topic: pantheon The Pantheon desktop environment 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: docker tools labels Dec 9, 2024
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions and removed 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: vim 6.topic: fetch 6.topic: nodejs 6.topic: hardware 6.topic: pantheon The Pantheon desktop environment 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: docker tools 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: vscode 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: julia 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Dec 9, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamLukeYes SamLukeYes Awaiting requested review from SamLukeYes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cswimr @SamLukeYes @NixOSInfra