swiftpm2nix: use nurl instead of nix-prefetch-git #358546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
force-pushed
the
swiftpm2nix-nurl
branch
from
3ff499e to
d5cd1d6
Compare
ofalvai
force-pushed
the
swiftpm2nix-nurl
branch
from
d5cd1d6 to
cfc3088
Compare
emilazy
approved these changes
Nov 23, 2024
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-24.11 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #358352 with the suggestion of @emilazy.
Use nurl for fetching the dependencies and computing their hashes. Note that the old script used the non-SRI base32 hash output of
nix-prefetch-git, whilenurlreturns the SRI base64 hash, so this PR results in different generated hash values , but this shouldn't cause an issue.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.