retroarch: refactor #358405
Open
retroarch: refactor #358405
+338
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
force-pushed
the
retroarch-refactor-pt2
branch
from
6368af5
to
7485cd8
Compare
github-actions
bot
added
the
6.topic: nixos
This comment was marked as outdated.
This comment was marked as outdated.
thiagokokada
force-pushed
the
retroarch-refactor-pt2
branch
from
3c9a0ed
to
723ff34
Compare
|
@ofborg build retroarch-free |
|
|
CC @aanderse for review. |
13 tasks
gepbird
previously requested changes
Nov 23, 2024
There was a problem hiding this comment.
fa080ef (#358405) contains more changes than just a by-name move, maybe you should split up the package rename changes.
Similar things with 31dc6a6 (#358405).
thiagokokada
force-pushed
the
retroarch-refactor-pt2
branch
from
723ff34
to
36958ad
Compare
Done. |
|
@ofborg build retroarch-free |
wegank
added
the
12.approvals: 1
gepbird
added
12.approvals: 2
thiagokokada
force-pushed
the
retroarch-refactor-pt2
branch
from
36958ad
to
5785c07
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Submit issue upstream and link back here? |
It could be an issue with our wrapper or something else we do though, this is why I prefer to not report it right now. If I can reproduce this with vanilla RetroArch I could report it, but unless someone is willing to do the report I don't have time right now. |
Actually testing this it doesn't solve the issue. Let me drop this commit because otherwise this complicates the derivation for no good reason. |
thiagokokada
force-pushed
the
retroarch-refactor-pt2
branch
from
000e97f
to
50c7be1
Compare
|
@ofborg build retroarch-free |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgs/by-nameretroarchFulltoretroarch-fullandretroarchBaretoretroarch-bare(also add aliases to the old names)retroarch.withCoreshelper to make it easier to add cores to RetroArch and it is more inline with e.g.:python3.withPackagesretroarch-free, a derivation of RetroArch with only free cores (e.g.: can be built in OfBorg)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.