shntool: 3.0.10 -> 3.0.10+git20130108.4ca41f4-1 #357635
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
tdeebswihart
force-pushed
the
patch-shntool
branch
from
d75276e
to
d17f3cb
Compare
|
I attempted to review this using |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
jcumming
approved these changes
Nov 21, 2024
tdeebswihart
force-pushed
the
patch-shntool
branch
from
d17f3cb
to
dc5239b
Compare
Sounds good! I've removed the commented-out patches line (that predated pulling the debian sources directly), so it's good to go |
|
@NixOS/nixpkgs-merge-bot merge |
Aleksanaa
changed the title
|
@ofborg build shntool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
I'm updating
shntoolto source its code from the Debian folks and to use their patches; I encountered issues using shntool that were fixed by these.While here I updated its homepage to the debian tracker; the original homepage now returns a 404.
Full details about the Debian package for this can be found on their tracker.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = true:nix-shell --option sandbox true -E "with import <nixpkgs> {}; callPackage ./package.nix {}"nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.