Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-spellcheck: move to pkgs/by-name #356513

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

newAM
Copy link
Member

@newAM newAM commented Nov 16, 2024

As titled.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 17, 2024
pkgs/by-name/ca/cargo-spellcheck/package.nix Outdated Show resolved Hide resolved
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically labels Nov 17, 2024
@newAM newAM force-pushed the cargo-spellcheck-by-name branch from e930b87 to f9a635a Compare December 1, 2024 17:15
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 1, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 1, 2024
@ofborg ofborg bot requested a review from matthiasbeyer December 2, 2024 07:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 2, 2024
@getchoo
Copy link
Member

getchoo commented Dec 3, 2024

@ofborg build cargo-spellcheck

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356513


x86_64-darwin

✅ 1 package built:
  • cargo-spellcheck

aarch64-darwin

✅ 1 package built:
  • cargo-spellcheck

@getchoo getchoo merged commit afd9ca8 into NixOS:master Dec 3, 2024
18 of 20 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Successfully created backport PR for release-24.11:

getchoo pushed a commit that referenced this pull request Dec 3, 2024
)

cargo-spellcheck: move to pkgs/by-name (#356513)

(cherry picked from commit afd9ca8)

Co-authored-by: Alex Martens <[email protected]>
hsjobeki pushed a commit to hsjobeki/nixpkgs that referenced this pull request Dec 3, 2024
@newAM newAM deleted the cargo-spellcheck-by-name branch December 3, 2024 15:32
prinzdezibel pushed a commit to prinzdezibel/nixpkgs that referenced this pull request Dec 4, 2024
…S#361331)

cargo-spellcheck: move to pkgs/by-name (NixOS#356513)

(cherry picked from commit afd9ca8)

Co-authored-by: Alex Martens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants