zed-editor: downgrade nodejs

[niklaskorz]

See #356257 and #355919.
Downgrades nodejs from latest to 22, as 23 (latest) currently fails to build.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[emilazy]

Seems good to me; I’ll give Zed users a chance to respond.

We could pick Node 22 instead, as it’s about to become the main LTS and the default for 25.05, if it’s likely that some things might use functionality not available in 20.

cc @jansol @GaetanLepage

[niklaskorz]

Seems good to me; I’ll give Zed users a chance to respond.

We could pick Node 22 instead, as it’s about to become the main LTS and the default for 25.05, if it’s likely that some things might use functionality not available in 20.

cc @jansol @GaetanLepage

22 also is what Zed itself downloads if no Node installation is found, so that seems fair enough.

The only concern I have is that we then have to manually update nodejs in zed-editor while sticking to nodejs means it will be updated automatically in the future.

Edit: Also, this should probably just take nodejs as parameter in either case and pin the version in all-packages.nix, right?

[emilazy]

We could leave it as nodejs_22 for 24.11 but unpin to nodejs once it becomes the default on unstable.

I’m agnostic about all-packages.nix – I personally prefer to keep version overrides with the definition for legibility but other people prefer to do it differently to make the override API more sensible.

[niklaskorz]

We could leave it as nodejs_22 for 24.11 but unpin to nodejs once it becomes the default on unstable.

I’m agnostic about all-packages.nix – I personally prefer to keep version overrides with the definition for legibility but other people prefer to do it differently to make the override API more sensible.

Alright, for consistency sake (i.e., we already have apple-sdk_15), I won't override nodejs in all-packages and instead directly use nodejs_22 in the package.

[aduh95]

I won't override nodejs in all-packages and instead directly use nodejs_22 in the package.

FWIW it's already done on staging:

nixpkgs/pkgs/top-level/all-packages.nix

Line 4299 in 3a60581

nodejs = hiPrio nodejs_22;

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356459

---

x86_64-linux

✅ 1 package built:

• zed-editor

---

aarch64-linux

✅ 1 package built:

• zed-editor

---

x86_64-darwin

---

aarch64-darwin

[emilazy]

Feel free to cc me on a staging PR to unpin the version after the automatic merge goes through.

[github-actions]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] zed-editor: downgrade nodejs #356500