amulet-map-editor: init at 0.10.37 #356035
Open
+570
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: lib
ofborg
bot
added
8.has: package (new)
getchoo
reviewed
Dec 10, 2024
There was a problem hiding this comment.
You could also make this a python module and use python3Packages.toPythonApplication here -- which would help you avoid so many with python3.pkgs;, etc. Up to you though ;)
pluiedev
force-pushed
the
push-yyrtrlztnppr
branch
from
0675b24 to
1f6cebd
Compare
pluiedev
force-pushed
the
push-yyrtrlztnppr
branch
from
1f6cebd to
be117c4
Compare
getchoo
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Not tested, but diff LGTM and everything builds
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356035
aarch64-linux
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
✅ 23 packages built:
- amulet-map-editor
- amulet-map-editor.dist
- nixpkgs-manual
- python311Packages.amulet-core
- python311Packages.amulet-core.dist
- python311Packages.amulet-leveldb
- python311Packages.amulet-leveldb.dist
- python311Packages.amulet-nbt
- python311Packages.amulet-nbt.dist
- python311Packages.minecraft-resource-pack
- python311Packages.minecraft-resource-pack.dist
- python311Packages.pymctranslate
- python311Packages.pymctranslate.dist
- python312Packages.amulet-core
- python312Packages.amulet-core.dist
- python312Packages.amulet-leveldb
- python312Packages.amulet-leveldb.dist
- python312Packages.amulet-nbt
- python312Packages.amulet-nbt.dist
- python312Packages.minecraft-resource-pack
- python312Packages.minecraft-resource-pack.dist
- python312Packages.pymctranslate
- python312Packages.pymctranslate.dist
getchoo
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201016
Got it to work for a brief moment before somehow it just starts to SIGBUS everywhere. Needs further investigation/reproduction
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.