Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncspot: migrate to new darwin SDK pattern #355809

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Nov 14, 2024

Part of #354146

Fixes a build failure on x86_64-darwin that appeared in https://hydra.nixos.org/build/277150358. ZHF #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added 0.kind: build failure A package fails to build 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign labels Nov 14, 2024
@getchoo
Copy link
Member Author

getchoo commented Nov 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355809


x86_64-darwin

✅ 1 package built:
  • ncspot

aarch64-darwin

✅ 1 package built:
  • ncspot

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 14, 2024
@Scrumplex Scrumplex merged commit 83821ee into NixOS:master Nov 14, 2024
13 of 14 checks passed
@getchoo getchoo deleted the pkgs/ncspot/darwin-sdk branch November 14, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants