{gpauth,gpclient}: Minor changes + 2.3.7 -> 2.3.9 #355768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
Binary-Eater
force-pushed
the
gpclient-cleanup
branch
from
22c1dfb to
96cc5d4
Compare
m1dugh
approved these changes
Nov 13, 2024
jerith666
approved these changes
Nov 14, 2024
tomodachi94
changed the title
tomodachi94
approved these changes
Nov 14, 2024
@m1dugh has contributed a lot in NixOS#350777. The upstream state of the GUI component combined with the paid licensing model has made it daunting to consider integrating into nixpkgs. Instead, add @m1dugh as a co-maintainer for the existing v2 packages. Signed-off-by: Rahul Rameshbabu <[email protected]>
PR NixOS#308324 describes the various issues with using absolute paths in desktop entries. This change makes gpclient comply with the direction stated in that PR. Suggested-by: @tomodachi94 Signed-off-by: Rahul Rameshbabu <[email protected]>
Signed-off-by: Rahul Rameshbabu <[email protected]>
Binary-Eater
force-pushed
the
gpclient-cleanup
branch
from
96cc5d4 to
d42fed4
Compare
|
@tomodachi94 I went ahead with updating my commit messages. Thanks for the feedback. We have time before 24.11 is staged, so no point in rushing these things. |
tomodachi94
approved these changes
Nov 14, 2024
|
Happy to merge this after CI passes, given that there are no other blocking comments in the meantime 🙂 |
wegank
added
the
12.approvals: 3+
ofborg
bot
added
11.by: package-maintainer
m1dugh
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.