aegisub: update OpenAL build for new Darwin SDK #355749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahec
force-pushed
the
aegisub-openal-darwin
branch
from
6860dea to
7ae5035
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
|
Please put the formatting in a separate commit. |
sarahec
force-pushed
the
aegisub-openal-darwin
branch
from
7ae5035 to
75b704c
Compare
I hand-reverted the spots where nixfmt rearranged things. |
tjni
approved these changes
Nov 15, 2024
|
I had to move the patch into the upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aegisubhas the option to be built with or without OpenAL. On Darwin, this was done by explicitly importing the OpenAL framework from the SDK (andopenalon other platforms).The new Darwin setup imports the whole SDK, including OpenAL. So we need to explicitly exclude it when building without openal support.
Based on this review comment by @tjni
Darwin migration Tracker: #354146
IMPORTANT
Merge #355564 first.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.