antiprism: 0.30 -> 0.32 #354091
Merged
antiprism: 0.30 -> 0.32 #354091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
added
the
0.kind: ZHF Fixes
tomodachi94
requested changes
Nov 6, 2024
|
|
Lgtm. Would have appreciated a comment on the non-blocking note at #354091 (comment), but it's fine 🙂 Happy to merge after CI turns green. |
tomodachi94
approved these changes
Nov 6, 2024
tomodachi94
added
the
12.approvals: 1
I just kicked off a nixpkgs-review before I left for a bit, I wasn't ignoring it :P |
|
Ah my bad :) approved again |
tomodachi94
approved these changes
Nov 6, 2024
|
AndersonTorres
approved these changes
Nov 7, 2024
fabianhjr
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
ZHF: #352882
https://hydra.nixos.org/build/276847220/nixlog/1
Current version broken on darwin, bumping to latest tag.
antiprism/antiprism@0.30...0.32#diff-7ee66c4f1536ac84dc5bbff1b8312e2eef24b974b3e48a5c5c2bcfdf2eb8f3ce
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.