Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.subliminal: mark as not broken #353672

Merged
merged 1 commit into from
Nov 10, 2024
Merged

python3Packages.subliminal: mark as not broken #353672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkgs/development/python-modules/subliminal/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,5 @@ buildPythonPackage rec {
changelog = "https://github.com/Diaoul/subliminal/blob/${version}/HISTORY.rst";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ doronbehar ];
# Too many tests fail ever since a certain python-updates merge, see:
# https://github.com/Diaoul/subliminal/issues/1062 . Disabling tests
# alltogether may produce a not completly failing executable, but that
# executable apparently isn't able to download subtitles at all.
broken = true;
};
}