Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.elpi: add 1.18.2 #352344

Merged
merged 1 commit into from
Oct 30, 2024
Merged

ocamlPackages.elpi: add 1.18.2 #352344

merged 1 commit into from
Oct 30, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Oct 30, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@proux01 proux01 mentioned this pull request Oct 30, 2024
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 30, 2024
@proux01
Copy link
Contributor Author

proux01 commented Oct 30, 2024

@vbgl CI green (we need that for the CI of coq-elpi: LPCIC/coq-elpi#712 )

@vbgl vbgl marked this pull request as ready for review October 30, 2024 16:52
@vbgl vbgl merged commit 55df3a2 into NixOS:master Oct 30, 2024
26 of 27 checks passed
@nix-owners nix-owners bot requested a review from ulrikstrid October 30, 2024 16:53
@proux01 proux01 deleted the elpi_1_18_2 branch October 30, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @vbgl