Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfem: init at 4.7 #352118

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

mfem: init at 4.7 #352118

wants to merge 4 commits into from

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 29, 2024

Motivation

MFEM is a free, lightweight, scalable C++ library for finite element methods.

This commit init mfem built with optional dependencies mpi, suitesparse, mumps_par.

These three dependencies are commonly used in mfem examples so they will be set with by default.

Need more careful consideration before merge.

  • keep int/float size align with its dependency
  • distinguish buildInputs and propagatedBuildInputs
  • make sure there is no redundent or missing dependencies for each combination of options
  • people who are interested in building mfem prefer to build mumps_par with parmetis which is unfree and thus by default disabled, how can we override mfem built with thoes unfree dependencies easily.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mf/mfem/package.nix Outdated Show resolved Hide resolved
@qbisi qbisi marked this pull request as draft October 29, 2024 15:02
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2024
@qbisi qbisi force-pushed the mfem branch 2 times, most recently from 7295c0c to daf97ca Compare November 4, 2024 12:37
@qbisi qbisi marked this pull request as ready for review November 4, 2024 12:39
@qbisi qbisi requested review from nim65s and NickCao November 4, 2024 12:43
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, builds fine or x86_64-linux, test pass

NB: this include #355128

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 12, 2024
@qbisi qbisi marked this pull request as draft November 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants