Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/test/fcitx5: add assertion message #351646

Merged

Conversation

h7x4
Copy link
Member

@h7x4 h7x4 commented Oct 27, 2024

Followup for #346680

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 27, 2024
@h7x4
Copy link
Member Author

h7x4 commented Oct 28, 2024

@ofborg test fcitx5

2 similar comments
@h7x4
Copy link
Member Author

h7x4 commented Oct 28, 2024

@ofborg test fcitx5

@h7x4
Copy link
Member Author

h7x4 commented Oct 29, 2024

@ofborg test fcitx5

@h7x4
Copy link
Member Author

h7x4 commented Oct 29, 2024

Would be real nice if this one could fail with the same assertion error that the previous PR failed with...

@h7x4
Copy link
Member Author

h7x4 commented Oct 30, 2024

@ofborg test fcitx5

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 12, 2024
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test actually fails because fcitx_test.out doesn't exist. So this won't help to debug it.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 21, 2024
@h7x4
Copy link
Member Author

h7x4 commented Dec 22, 2024

Are you sure? If fcitx_test.out did not exist, I would expect the test to fail at file_content = machine.succeed("cat ${user.home}/fcitx_test.out") instead of passing through and throwing the assertion error at the next line (https://github.com/NixOS/nixpkgs/runs/32108566210)

@FliegendeWurst
Copy link
Member

Oh right. The particular run you linked is a timeout, but the other one does indeed hit the assertion.

@FliegendeWurst FliegendeWurst merged commit fb13bab into NixOS:master Dec 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants