-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/test/fcitx5: add assertion message #351646
nixos/test/fcitx5: add assertion message #351646
Conversation
@ofborg test fcitx5 |
Would be real nice if this one could fail with the same assertion error that the previous PR failed with... |
@ofborg test fcitx5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test actually fails because fcitx_test.out doesn't exist. So this won't help to debug it.
Are you sure? If fcitx_test.out did not exist, I would expect the test to fail at |
Oh right. The particular run you linked is a timeout, but the other one does indeed hit the assertion. |
Followup for #346680
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.