samba: fix darwin #351117
Closed
samba: fix darwin #351117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
paparodeo
force-pushed
the
samba-darwin-fix
branch
from
d4e00b0 to
0bc8c7d
Compare
paparodeo
force-pushed
the
samba-darwin-fix
branch
from
0bc8c7d to
7014b40
Compare
ofborg
bot
added
10.rebuild-linux: 101-500
and removed
10.rebuild-linux: 0
paparodeo
force-pushed
the
samba-darwin-fix
branch
from
7014b40 to
919d8c1
Compare
the cups headers are part of the sdk but the library is not, which causes configure to detect cups but the build fails with a link error. explicitly enable / disable cups based on `enablePrinting` flag.
paparodeo
force-pushed
the
samba-darwin-fix
branch
from
919d8c1 to
d7ca165
Compare
vcunat
added a commit
that referenced
this pull request
Oct 26, 2024
|
Uh, pushed as 2a44ea3. Git's rebasing of merges is... temperamental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Darwin sdk now includes the cups headers which configure detects but the build fails to link due to the missing cups library. use a configure flag to explicitly enable / disable cups (default is off).
there is no linux change (cups is not used by default) but the additional configure flags trigger a rebuild
https://hydra.nixos.org/build/276120820
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.