gzip: use makeShellWrapper instead of makeWrapper

[Cynerd]

makeWrapper is in default makeShellWrapper but sometimes it is beneficial to switch it in overlay to makeBinaryWrapper, but gzip is injecting shell expansion that doesn't work binary wrapper. Thus this takes shell wrapper explicitly as a dependency now.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SuperSandro2000]

sometimes it is beneficial to switch it in overlay to makeBinaryWrapper, but gzip is injecting shell expansion that doesn't work binary wrapper.

You can always override in the overlay. Why isn't that enough here?

[Cynerd]

sometimes it is beneficial to switch it in overlay to makeBinaryWrapper, but gzip is injecting shell expansion that doesn't work binary wrapper.

You can always override in the overlay. Why isn't that enough here?

Yes, I can, and that is what I am doing. The issue is that if you do not know about it and thus do not do it, you get pretty cryptic errors when fetching packages (gzip: ${GZIP_NO_TIMESTAMPS:+-n}.gz: No such file or directory). I think that if the package relies on the wrapper being a shell, then it should explicitly pull in the shell variant and not rely on it being the default option.