Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyfetch: 1.4.11 -> 1.99.0; use modern standards #350800

Merged
merged 4 commits into from
Oct 25, 2024
Merged

hyfetch: 1.4.11 -> 1.99.0; use modern standards #350800

merged 4 commits into from
Oct 25, 2024

Conversation

isabelroses
Copy link
Member

https://github.com/hykilpikonna/hyfetch/releases/tag/1.99.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

donovanglover
donovanglover approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 23, 2024
@ofborg ofborg bot requested a review from YisuiDenghua October 24, 2024 00:59
getchoo
getchoo approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to adopt pyproject while we're at this, though

pkgs/by-name/hy/hyfetch/package.nix Outdated Show resolved Hide resolved
@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 24, 2024
@isabelroses isabelroses requested a review from getchoo October 24, 2024 19:31
@isabelroses isabelroses removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 24, 2024
getchoo
getchoo requested changes Oct 24, 2024
View reviewed changes
pkgs/by-name/hy/hyfetch/package.nix Outdated Show resolved Hide resolved
@isabelroses isabelroses requested a review from getchoo October 24, 2024 21:06
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 24, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 25, 2024
@donovanglover donovanglover merged commit b523b20 into NixOS:master Oct 25, 2024
28 of 30 checks passed
@isabelroses isabelroses deleted the pkgs/hyfetch/update branch October 25, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@YisuiDenghua YisuiDenghua Awaiting requested review from YisuiDenghua

@donovanglover donovanglover Awaiting requested review from donovanglover

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isabelroses @donovanglover @getchoo