Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versatiles: init at 0.12.10 #350343

Merged
merged 2 commits into from
Oct 27, 2024
Merged

versatiles: init at 0.12.10 #350343

merged 2 commits into from
Oct 27, 2024

Conversation

wilhelmines
Copy link
Member

@wilhelmines wilhelmines commented Oct 21, 2024

VersaTiles

This is a pull request to add VersaTiles to nixpkgs.

The short description from the github repo:
VersaTiles - A toolbox for converting, checking and serving map tiles in various formats.
VersaTiles is a Rust-based project designed for processing and serving tile data efficiently. It supports multiple tile formats and offers various functionalities for handling tile data.

More information can be found on the project's website https://versatiles.org as well as on the GitHub repo: https://github.com/versatiles-org/versatiles-rs

Currently, I'm not included in the development of VersaTiles, but have decided to create the package based on a wish on their contributing page. I plan to be the package maintainer. The lead developer knows about my effort and helped me with fixing related bugs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 21, 2024
Copy link
Member

@herbetom herbetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.12.10 got released in the meantime.

pkgs/by-name/ve/versatiles/package.nix Outdated Show resolved Hide resolved
@herbetom
Copy link
Member

With #350343 and the versatiles: adding changelog link commit in mind: Maybe take a look at the git rebase --interactive HEAD~3 command (where HEAD~3 is the number of commits but there are a number of options to specify which commits you want to interact with). This allows you to edit, reword, squash and do other stuff with commits :)

@herbetom
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350343


x86_64-linux

✅ 1 package built:
  • versatiles

aarch64-linux

✅ 1 package built:
  • versatiles

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have done all the changes, please squash into two commits only: maintainers: add wilhelmines and versatiles: init at 0.12.9

@wilhelmines wilhelmines changed the title versatiles: init at 0.12.9 versatiles: init at 0.12.10 Oct 27, 2024
@wilhelmines
Copy link
Member Author

Hey,
thanks for your responses.
I implemented all of your suggestions.

  • The init version is now v0.12.10
  • rev refers to the version instead of the commit hash
  • The description is shortend
  • lib is only used where necessary
  • platform syntax is changed
  • commits are squashed

If I missed anything, I'm happy to get a response.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Oct 27, 2024
@wilhelmines
Copy link
Member Author

I made a mistake. How can I remove the other commits that are not part of this PR?

versatiles: adding changelog link

versatiles: added recommended changes

versatiles: Changed description
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Oct 27, 2024
@wilhelmines
Copy link
Member Author

I found the solution by myself.

@Aleksanaa Aleksanaa merged commit 786eb00 into NixOS:master Oct 27, 2024
28 of 29 checks passed
@herbetom herbetom added the backport release-24.05 Backport PR automatically label Oct 30, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants