Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "aliases: cleanup old throw aliases" #350292

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Revert "aliases: cleanup old throw aliases" #350292

merged 2 commits into from
Oct 21, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Oct 21, 2024

#350289 broke eval

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Revert "aliases: manual cleanup of nodejs-{14,16} variants that were …
390b451 
…left by previous script"

The removals broke evaluation.

This reverts commit ffa3d12.
@emilazy
Revert "aliases: cleanup old throw aliases"
8a70e31 
The removals broke evaluation.

This reverts commit 47f610f.
@emilazy emilazy merged commit e056730 into NixOS:master Oct 21, 2024
10 of 11 checks passed
@emilazy emilazy deleted the push-nsyywzulkozu branch October 21, 2024 17:45
@bendlas bendlas mentioned this pull request Jan 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emilazy