vimPlugins: update on 2024-10-20 #349875
Merged
vimPlugins: update on 2024-10-20 #349875
+128
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
GaetanLepage
force-pushed
the
vim-plugins-update
branch
from
71ac5de
to
80efa2b
Compare
GaetanLepage
force-pushed
the
vim-plugins-update
branch
from
80efa2b
to
4807c2e
Compare
GaetanLepage
changed the title
|
khaneliman
approved these changes
Oct 20, 2024
| SELECTED_FILEPATH, | ||
| create_ranger_cmd_flags(create_cmd_values(opts.keybinds)), | ||
| get_absolute_argument() | ||
| @@ -209,7 +209,7 @@ end |
There was a problem hiding this comment.
Is this a version bump fix ? Or has it always needed this? Might be nice to be a separate commit and add a note about reason for it.
There was a problem hiding this comment.
Yes, this is a simple adaptation to the existing patch for ranger.nvim.
As there has been no fundamental changes to the patch, I feel like it's fine to leave inside the update commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.