Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kangaru: init at 4.3.2 #349770

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Oct 19, 2024

Add new package for https://github.com/gracicot/kangaru.

Kangaru is an inversion of control container for C++11, C++14 and later. It provides many features to automate dependency injection and reduce the amount of wiring boilerplate in your code.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/) Header only
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/ka/kangaru/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ka/kangaru/package.nix Outdated Show resolved Hide resolved
@fliiiix
Copy link
Contributor Author

fliiiix commented Nov 2, 2024

@FliegendeWurst thanks for the review btw other question should i squash these commits together or not?

@FliegendeWurst
Copy link
Member

Yes, they should be squashed.

@fliiiix fliiiix force-pushed the feature/add-kangaru branch from ba7e900 to 7642cf2 Compare November 2, 2024 16:50
@fliiiix
Copy link
Contributor Author

fliiiix commented Nov 2, 2024

squashed and rebased to latest master

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@SuperSandro2000 SuperSandro2000 merged commit 9880ca7 into NixOS:master Nov 12, 2024
29 checks passed
@fliiiix fliiiix deleted the feature/add-kangaru branch November 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants