electrum: fix build, update to 4.5.6 #349753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the update to version 5 with NixOS@7cdaa0b , the `python3Packages.protobuf` package no longer provides the `protoc` program. Instead, one has to add the `protobuf` package (not the python package) directly.
Release notes: https://github.com/spesmilo/electrum/blob/4.5.6/RELEASE-NOTES Beginning with this update, electrum includes its tests in its release tarballs, cf. spesmilo/electrum#9207 spesmilo/electrum@3ec16a0 https://github.com/spesmilo/electrum/blob/4.5.6/RELEASE-NOTES#L31 Therefore we drop the separate download of tests.
This reverts commit 54bea47. It is no longer needed as electrum 4.5.6 raised its `ledger-bitcoin` version limit to "<0.4", cf. spesmilo/electrum#9035 spesmilo/electrum@719292f https://github.com/spesmilo/electrum/blob/4.5.6/RELEASE-NOTES#L24
.. replacing `nativeBuildInputs` and `propagatedBuildInputs`.
|
@GrahamcOfBorg build electrum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python3Packages.protobufpackage no longer provides theprotocprogram, causing theelectrumbuild to fail. Instead, one has to addpkgs.protobuf(not the python package) directly.electrumto newest version 4.5.6. Notable changes (documented in the release notes) include:ledger-bitcoingot bumped to "<0.4". This allows us to unpin the version.This should fix #349746
Notifying maintainers: @joachifm @np @prusnak @chewblacka
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Result of
nixpkgs-reviewrun on x86_64-linux 12 packages built:
Add a 👍 reaction to pull requests you find important.