Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system76-io-dkms: 1.0.2 -> 1.0.4 #349436

Closed
wants to merge 1 commit into from
Closed

system76-io-dkms: 1.0.2 -> 1.0.4 #349436

wants to merge 1 commit into from

Conversation

ahoneybun
Copy link
Contributor

@ahoneybun ahoneybun commented Oct 18, 2024 •
edited
Loading

This does the following:

  • Adds support for thelio-io v2
  • Adds support for aarch64 (arm64 for Debian based)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ahoneybun ahoneybun mentioned this pull request Oct 18, 2024
Merged
13 tasks
@ahoneybun
Copy link
Contributor Author

Should be updated now.

@ahoneybun ahoneybun requested a review from khumba October 18, 2024 13:12
@ahoneybun ahoneybun marked this pull request as ready for review October 18, 2024 13:22
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 18, 2024
@ahoneybun
Copy link
Contributor Author

Result of nixpkgs-review pr 349436 run on x86_64-linux

2 packages marked as broken and skipped:
linuxKernel.packages.linux_5_4_hardened.system76-io linuxPackages_5_4_hardened.system76-io

17 packages built:
linuxKernel.packages.linux_5_10.system76-io linuxPackages_5_10_hardened.system76-io linuxKernel.packages.linux_5_15.system76-io linuxPackages_5_15_hardened.system76-io linuxKernel.packages.linux_5_4.system76-io linuxKernel.packages.linux_6_1.system76-io linuxKernel.packages.linux_6_10.system76-io linuxPackages_latest.system76-io linuxPackages_6_1_hardened.system76-io linuxPackages.system76-io linuxPackages_hardened.system76-io linuxPackages_latest-libre.system76-io linuxPackages-libre.system76-io linuxPackages_lqx.system76-io linuxPackages_xanmod.system76-io linuxPackages_xanmod_latest.system76-io linuxPackages_zen.system76-io

@khumba
Copy link
Contributor

khumba commented Oct 19, 2024

Thanks! This looks good to me now. You'll need to ask someone else to review and merge though, I don't have a commit bit.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 19, 2024
@ahoneybun ahoneybun requested a review from nyabinary October 21, 2024 13:40
nyabinary
nyabinary suggested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@nyabinary nyabinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes :3

pkgs/os-specific/linux/system76-io/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/system76-io/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/system76-io/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/system76-io/default.nix Outdated Show resolved Hide resolved
@ahoneybun
Copy link
Contributor Author

Should be fixed now.

@ahoneybun ahoneybun requested a review from khumba October 21, 2024 15:31
@ahoneybun
system76-io-dkms: 1.0.2 -> 1.0.4
202cc3d 
add ahoneybun as co-maintainer
add aarch64-linux
Update sha256 and maintainers
change from sha256 to hash
@ahoneybun ahoneybun requested a review from nyabinary October 21, 2024 16:42
@nyabinary
Copy link
Contributor

nyabinary commented Oct 22, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349436

x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4.system76-io
  • linuxKernel.packages.linux_5_4_hardened.system76-io
  • linuxPackages_5_4_hardened.system76-io
❌ 2 packages failed to build:
  • linuxPackages_xanmod.system76-io (linuxKernel.packages.linux_xanmod.system76-io)
  • linuxPackages_xanmod_latest.system76-io (linuxKernel.packages.linux_xanmod_latest.system76-io ,linuxPackages_xanmod_stable.system76-io)
✅ 14 packages built:
  • linuxKernel.packages.linux_5_10.system76-io
  • linuxPackages_5_10_hardened.system76-io (linuxKernel.packages.linux_5_10_hardened.system76-io)
  • linuxKernel.packages.linux_5_15.system76-io
  • linuxPackages_5_15_hardened.system76-io (linuxKernel.packages.linux_5_15_hardened.system76-io)
  • linuxKernel.packages.linux_6_1.system76-io
  • linuxKernel.packages.linux_6_10.system76-io
  • linuxPackages_latest.system76-io (linuxKernel.packages.linux_6_11.system76-io)
  • linuxPackages_6_1_hardened.system76-io (linuxKernel.packages.linux_6_1_hardened.system76-io)
  • linuxPackages.system76-io (linuxKernel.packages.linux_6_6.system76-io)
  • linuxPackages_hardened.system76-io (linuxPackages_6_6_hardened.system76-io)
  • linuxPackages_latest-libre.system76-io (linuxKernel.packages.linux_latest_libre.system76-io)
  • linuxPackages-libre.system76-io (linuxKernel.packages.linux_libre.system76-io)
  • linuxPackages_lqx.system76-io (linuxKernel.packages.linux_lqx.system76-io)
  • linuxPackages_zen.system76-io (linuxKernel.packages.linux_zen.system76-io)

Seems like the 2 packages that failed was a result of running out of space? So it seems safe to me to approve this :P.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 22, 2024
@ahoneybun ahoneybun closed this by deleting the head repository Oct 23, 2024
@ahoneybun ahoneybun mentioned this pull request Oct 24, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyabinary nyabinary nyabinary approved these changes

@khumba khumba Awaiting requested review from khumba

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoneybun @khumba @nyabinary @wegank