python312Packages.opentelemetry-proto: fix protobuf version
#348738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
push-oxrvorwlqvtw
branch
2 times, most recently
from
c6fae6d to
d7a78f4
Compare
GaetanLepage
approved these changes
Oct 15, 2024
|
:') |
|
Oh boy... what should we do to fix this? |
I asked chat gpt and he told me |
natsukium
requested changes
Oct 15, 2024
pkgs/development/python-modules/opentelemetry-proto/default.nix
Outdated
Show resolved
Hide resolved
|
I haven't looked, but could you use this patch? open-telemetry/opentelemetry-python#4206 |
It requires protobuf <5.0 and >=3.19, therefore setting the `protobuf` dependency to `protobuf4`.
drupol
force-pushed
the
push-oxrvorwlqvtw
branch
from
d7a78f4 to
cd72fbd
Compare
There's ~20 commits there, can I use the PR diff URL ? https://patch-diff.githubusercontent.com/raw/open-telemetry/opentelemetry-python/pull/4206.diff |
|
We can use this commit since it has already been merged. |
This comment was marked as outdated.
This comment was marked as outdated.
|
There is already a commit to fix this python issue in 'staging' right now: 090f644 |
|
Thanks... it's going to be fixed in 2 weeks then? Is there a way to fix this earlier? |
|
Sorry, no. |
|
Fair enough, closing this. |
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-protorequiresprotobuf<5.0 and >=3.19, therefore setting theprotobufdependency toprotobuf4.Issue introduced in #338885
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.