Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aquamarine: 0.4.1 -> 0.4.3 #348436

Merged
merged 1 commit into from
Oct 14, 2024
Merged

aquamarine: 0.4.1 -> 0.4.3 #348436

merged 1 commit into from
Oct 14, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 14, 2024

Changes:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
Copy link
Contributor Author

trofi commented Oct 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348436


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • hyprlandPlugins.hycov
✅ 27 packages built:
  • aquamarine
  • aquamarine.dev
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprfocus
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprscroller
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@ofborg ofborg bot requested review from fufexan and JohnRTitor October 14, 2024 05:31
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 14, 2024
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built on my machine (x86_64-linux), tried to run nixpkgs-review but it crashes

❯ nix build github:trofi/nixpkgs/aquamarine-update#aquamarine
❯ eza --tree result/
result
└── lib
   ├── libaquamarine.so -> libaquamarine.so.3
   ├── libaquamarine.so.0.4.2
   └── libaquamarine.so.3 -> libaquamarine.so.0.4.2

@NickCao
Copy link
Member

NickCao commented Oct 14, 2024

0.4.3 just dropped.

@trofi trofi force-pushed the aquamarine-update branch from 6ca75a9 to 65a767b Compare October 14, 2024 15:28
@trofi trofi changed the title aquamarine: 0.4.1 -> 0.4.2 aquamarine: 0.4.1 -> 0.4.3 Oct 14, 2024
@trofi
Copy link
Contributor Author

trofi commented Oct 14, 2024

Good point! Updated to 0.4.3.

@trofi
Copy link
Contributor Author

trofi commented Oct 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348436


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • hyprlandPlugins.hycov
✅ 27 packages built:
  • aquamarine
  • aquamarine.dev
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprfocus
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprscroller
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@ofborg ofborg bot requested a review from fufexan October 14, 2024 16:34
@JohnRTitor JohnRTitor merged commit 273062d into NixOS:master Oct 14, 2024
37 of 38 checks passed
@trofi trofi deleted the aquamarine-update branch October 15, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants