zsh-abbr: adding completions + removing redudant bin directory #348162
Conversation
Icy-Thought
changed the title
|
@Lewenhaupt test out this PR and tell me if it works for you. :) |
ofborg
bot
added
11.by: package-maintainer
|
The rename of the plugin breaks the home-manager module which relies on the old naming. |
|
That we can fix after the merger of this PR since it's not a nix issue, but a home-manager one. (more like an exception too) |
But won't that break the home-manager module? |
|
I'll update the home-manager module to make sure that it works with after this PR merger. Apologies for the confusion earlier, got lost in my train of thoughts. |
|
I might've done something funny because of magit. Be right back with a fix if necessary. (in a learning phase still...) |
|
The issues should be fixed now. Do ping me if not! |
pkgs/shells/zsh/zsh-abbr/default.nix
Outdated
| install zsh-abbr.plugin.zsh zsh-abbr.zsh -Dt $out/share/zsh/${pname}/ | ||
| install completions/_abbr -Dt $out/share/zsh/${pname}/completions/ |
There was a problem hiding this comment.
| install zsh-abbr.plugin.zsh zsh-abbr.zsh -Dt $out/share/zsh/${pname}/ | |
| install completions/_abbr -Dt $out/share/zsh/${pname}/completions/ | |
| install zsh-abbr.plugin.zsh zsh-abbr.zsh -Dt $out/share/zsh/zsh-abbr/ | |
| install completions/_abbr -Dt $out/share/zsh/zsh-abbr/completions/ |
There was a problem hiding this comment.
Is this a trivial change? Since it already outputs the files to that exact directory.
|
At this point it's rewriting the whole |
Things done
zsh-abbr.plugin.zshbecause most plugins share that structure and automating the installation process would be kinder if we omit this exception.completions/_abbr, which allows completions for theabbrcommand in zsh. Only benefits people who are not creating their abbreviation file through nix.$out/binbecause it only contains the changelog file. Not necessary for using the package.Also, it should resolve #348110.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.