-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/actual: init at 24.10.1 #347825
nixos/actual: init at 24.10.1 #347825
Conversation
0503788
to
4590c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Thx for finishing the module.
4590c78
to
91adb3e
Compare
Fair points, all comments were addressed |
91adb3e
to
78d7057
Compare
diff --git a/pkgs/by-name/ac/actual-server/package.nix b/pkgs/by-name/ac/actual-server/package.nix
index c2daf4ea2060..c3284a8e3381 100644
--- a/pkgs/by-name/ac/actual-server/package.nix
+++ b/pkgs/by-name/ac/actual-server/package.nix
@@ -9,14 +9,15 @@
nodejs,
yarn,
nixosTests,
+ nix-update-script,
}:
let
- version = "24.10.1";
+ version = "24.11.0";
src = fetchFromGitHub {
owner = "actualbudget";
repo = "actual-server";
rev = "v${version}";
- hash = "sha256-VJAD+lNamwuYmiPJLXkum6piGi5zLOHBp8cUeZagb4s=";
+ hash = "sha256-tEanuY2GRufLbyjkhwFcsn8Nl3wlf/PbVJjzJfTTk7g=";
};
# We cannot use fetchYarnDeps because that doesn't support yarn2/berry
@@ -72,7 +73,7 @@ let
outputHashAlgo = "sha256";
outputHashMode = "recursive";
- outputHash = "sha256-eNpOS21pkamugoYVhzsEnstxeVN/J06yDZcshfr0Ek4=";
+ outputHash = "sha256-yda1GdnPRHOoaJzkGz755Lm9/J60lFDsVvBgf/2e+3I=";
};
in
stdenv.mkDerivation {
@@ -101,6 +102,7 @@ stdenv.mkDerivation {
passthru = {
inherit offlineCache;
tests = nixosTests.actual;
+ passthru.updateScript = nix-update-script { };
};
meta = { |
78d7057
to
ea062fb
Compare
|
Nodejs 18 will be removed before the 25.05 release. Actual recommends an LTS version, v20 is one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit.
Oh i see, I got the info from their Dockerfile which is still based on 18. |
156f74b
to
1c6f9e2
Compare
I've also opened actualbudget/actual-server#524 for Node 22 support upstream. |
yarn config set --json supportedArchitectures "$SUPPORTED_ARCHITECTURES" | ||
yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this will only build the native libraries for the current platform, meaning the content hash will vary (as seen by ofborg).
I already tried to fix it (by building in the package derivation), but couldn't make it work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution would be to use fetchYarnDeps
but we can't since it doesn't support v2/berry lockfiles yet. So i guess the best workaround we have is to set the output hash conditionally, at least this is what is done in the grafana build which also does that.
I guess this will make updates a bit more tedious, but we probably have no other choice.
1c6f9e2
to
0a11562
Compare
|
0a11562
to
8e6f346
Compare
|
Co-authored-by: PatrickDaG <[email protected]>
Co-authored-by: PatrickDaG <[email protected]>
8e6f346
to
93af2d0
Compare
|
Neat, thanks yall |
This adds a package, module and basic test for Actual, a privacy-focused app for managing finances. Closes #269069.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.