-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steamctl: init at 0.9.5 #347186
Open
jackwilsdon
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
jackwilsdon:steamctl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
steamctl: init at 0.9.5 #347186
+207
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
labels
Oct 7, 2024
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Oct 7, 2024
FliegendeWurst
added
the
6.topic: steam
Steam game store/launcher (store.steampowered.com)
label
Oct 23, 2024
FliegendeWurst
approved these changes
Nov 5, 2024
FliegendeWurst
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 5, 2024
natsukium
requested changes
Nov 7, 2024
Comment on lines
39
to
59
dependencies = [ | ||
cachetools | ||
gevent | ||
gevent-eventemitter | ||
protobuf | ||
pycryptodomex | ||
requests | ||
six | ||
vdf | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
dependencies = [ | |
cachetools | |
gevent | |
gevent-eventemitter | |
protobuf | |
pycryptodomex | |
requests | |
six | |
vdf | |
]; | |
dependencies = [ | |
cachetools | |
pycryptodomex | |
requests | |
six | |
vdf | |
]; | |
optional-dependencies = { | |
client = [ | |
gevent | |
gevent-eventemitter | |
protobuf | |
]; | |
}; |
jackwilsdon
force-pushed
the
steamctl
branch
from
November 11, 2024 20:41
9cac16e
to
ddce539
Compare
github-actions
bot
removed
the
6.topic: steam
Steam game store/launcher (store.steampowered.com)
label
Nov 11, 2024
I've made those changes 👍 also had to make some additional changes to get tests to run (recompiling protobufs, patch to support newer version of vcrpy). |
wegank
removed
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 11, 2024
jackwilsdon
force-pushed
the
steamctl
branch
from
November 11, 2024 22:13
ddce539
to
7f1ff0a
Compare
FliegendeWurst
approved these changes
Nov 12, 2024
FliegendeWurst
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 12, 2024
Actually it would be good to enable pyproject for all packages. diff --git a/pkgs/by-name/st/steamctl/package.nix b/pkgs/by-name/st/steamctl/package.nix
index e177a04103b6..f3e91ca2cdac 100644
--- a/pkgs/by-name/st/steamctl/package.nix
+++ b/pkgs/by-name/st/steamctl/package.nix
@@ -6,6 +6,7 @@
python3.pkgs.buildPythonApplication rec {
pname = "steamctl";
version = "0.9.5";
+ pyproject = true;
src = fetchFromGitHub {
owner = "ValvePython";
diff --git a/pkgs/development/python-modules/gevent-eventemitter/default.nix b/pkgs/development/python-modules/gevent-eventemitter/default.nix
index 7afdda25e1c3..15026b7e3e64 100644
--- a/pkgs/development/python-modules/gevent-eventemitter/default.nix
+++ b/pkgs/development/python-modules/gevent-eventemitter/default.nix
@@ -9,6 +9,7 @@
buildPythonPackage rec {
pname = "gevent-eventemitter";
version = "2.1";
+ pyproject = true;
src = fetchFromGitHub {
owner = "rossengeorgiev";
diff --git a/pkgs/development/python-modules/steam/default.nix b/pkgs/development/python-modules/steam/default.nix
index dee336f10440..c09bcbc50c81 100644
--- a/pkgs/development/python-modules/steam/default.nix
+++ b/pkgs/development/python-modules/steam/default.nix
@@ -21,6 +21,7 @@
buildPythonPackage rec {
pname = "steam";
version = "1.4.4";
+ pyproject = true;
src = fetchFromGitHub {
owner = "ValvePython"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.