Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steamctl: init at 0.9.5 #347186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

steamctl: init at 0.9.5 #347186

wants to merge 4 commits into from

Conversation

jackwilsdon
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jackwilsdon jackwilsdon requested a review from natsukium as a code owner October 7, 2024 22:38
@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Oct 7, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 7, 2024
@FliegendeWurst FliegendeWurst added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Oct 23, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2024
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/by-name/st/steamctl/package.nix Show resolved Hide resolved
pkgs/development/python-modules/steam/default.nix Outdated Show resolved Hide resolved
Comment on lines 39 to 59
dependencies = [
cachetools
gevent
gevent-eventemitter
protobuf
pycryptodomex
requests
six
vdf
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dependencies = [
cachetools
gevent
gevent-eventemitter
protobuf
pycryptodomex
requests
six
vdf
];
dependencies = [
cachetools
pycryptodomex
requests
six
vdf
];
optional-dependencies = {
client = [
gevent
gevent-eventemitter
protobuf
];
};

https://github.com/ValvePython/steam/blob/dd147db07f6797b787633cb90a8e9222dcb8b2f2/setup.py#L16-L33

@github-actions github-actions bot removed the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Nov 11, 2024
@jackwilsdon
Copy link
Contributor Author

I've made those changes 👍 also had to make some additional changes to get tests to run (recompiling protobufs, patch to support newer version of vcrpy).

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 12, 2024
@FliegendeWurst
Copy link
Member

Actually it would be good to enable pyproject for all packages.

diff --git a/pkgs/by-name/st/steamctl/package.nix b/pkgs/by-name/st/steamctl/package.nix
index e177a04103b6..f3e91ca2cdac 100644
--- a/pkgs/by-name/st/steamctl/package.nix
+++ b/pkgs/by-name/st/steamctl/package.nix
@@ -6,6 +6,7 @@
 python3.pkgs.buildPythonApplication rec {
   pname = "steamctl";
   version = "0.9.5";
+  pyproject = true;
 
   src = fetchFromGitHub {
     owner = "ValvePython";
diff --git a/pkgs/development/python-modules/gevent-eventemitter/default.nix b/pkgs/development/python-modules/gevent-eventemitter/default.nix
index 7afdda25e1c3..15026b7e3e64 100644
--- a/pkgs/development/python-modules/gevent-eventemitter/default.nix
+++ b/pkgs/development/python-modules/gevent-eventemitter/default.nix
@@ -9,6 +9,7 @@
 buildPythonPackage rec {
   pname = "gevent-eventemitter";
   version = "2.1";
+  pyproject = true;
 
   src = fetchFromGitHub {
     owner = "rossengeorgiev";
diff --git a/pkgs/development/python-modules/steam/default.nix b/pkgs/development/python-modules/steam/default.nix
index dee336f10440..c09bcbc50c81 100644
--- a/pkgs/development/python-modules/steam/default.nix
+++ b/pkgs/development/python-modules/steam/default.nix
@@ -21,6 +21,7 @@
 buildPythonPackage rec {
   pname = "steam";
   version = "1.4.4";
+  pyproject = true;
 
   src = fetchFromGitHub {
     owner = "ValvePython";

@FliegendeWurst FliegendeWurst self-requested a review December 31, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants