Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sly: init at 0.4.0 #347183

Merged
merged 1 commit into from
Nov 2, 2024
Merged

sly: init at 0.4.0 #347183

merged 1 commit into from
Nov 2, 2024

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Oct 7, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4741

@aucub aucub changed the title sly: init at 0.3.4 sly: init at 0.4.0 Oct 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Oct 25, 2024
@aucub aucub closed this Oct 28, 2024
@aucub aucub reopened this Oct 30, 2024
@Aleksanaa Aleksanaa mentioned this pull request Oct 31, 2024
Closed
13 tasks
Aleksanaa
Aleksanaa reviewed Oct 31, 2024
View reviewed changes
pkgs/by-name/sl/sly/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sl/sly/package.nix Outdated Show resolved Hide resolved
@Aleksanaa
Copy link
Member

Tested

@Aleksanaa Aleksanaa merged commit ed18f91 into NixOS:master Nov 2, 2024
27 of 28 checks passed
@aucub aucub deleted the sly branch November 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Sly
3 participants
@aucub @nixos-discourse @Aleksanaa